feat: migrate from setup.py/setuptools to pyproject.toml/hatch #99
Conversation
Faraz32123
commented
Jan 24, 2025
•
Faraz32123
commented
- migrate from setup.py/setuptools to pyproject.toml/hatch.
- This commit will keep the tutor-discovery in sync with the tutor core. For more details view this PR in tutor: feat: migrate from setup.py/setuptools to pyproject.toml/hatch tutor#1163.
- Completes tutor-discovery action item from [Epic] Migrate from setup.py/setuptools to pyproject.toml/hatch tutor#1190
|
I trust your judgment and I'm removing myself from the reviewers of this PR. |
Faraz32123
force-pushed
the
feat/faraz_migrate_from_setup_py_and_setuptools_to_pyproject_toml_and_hatch
branch
2 times, most recently
from
c383e30 to
527251d
Compare
| @@ -18,10 +18,8 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: Upgrade pip | |||
| run: python -m pip install --upgrade pip setuptools | |||
There was a problem hiding this comment.
should we not keep pip in here?
There was a problem hiding this comment.
I think it's just extra, as we are only upgrading pip, it's pre-compiled version is sufficient I think.
Plus, it's synchronized with the tutor core PR here.
| @@ -0,0 +1,3 @@ | |||
|
|
|||
There was a problem hiding this comment.
nit: empty line at the start.
There was a problem hiding this comment.
missed it! removed.
| [tool.hatch.build.targets.sdist] | ||
| # Disable strict naming, otherwise twine is not able to detect name/version | ||
| strict-naming = false | ||
| exclude = ["tests*"] |
There was a problem hiding this comment.
What's the difference in egg_file now that we are only excluding tests*? The MANIFEST.in included only certain files.
There was a problem hiding this comment.
I have now added include statement! may be we can restrict it to only templates and patches folder also!
- migrate from setup.py/setuptools to pyproject.toml/hatch. - This commit will keep the tutor-discovery in sync with the tutor core. For more details view this PR in tutor: overhangio/tutor#1163.
Faraz32123
force-pushed
the
feat/faraz_migrate_from_setup_py_and_setuptools_to_pyproject_toml_and_hatch
branch
from
527251d to
5143b96
Compare
| - name: Install dependencies | ||
| run: | | ||
| run: pip install pylint black | |
There was a problem hiding this comment.
Previously, we had a dev environment, which installed tutor[dev] (and that, handled these dependencies). Why we're not including that in our pyproject.toml?
test job logs specifically says that
WARNING: tutor-discovery 19.0.0 does not provide the extra 'dev'
