Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme update #98

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

mlabeeb03
Copy link
Contributor

@mlabeeb03 mlabeeb03 commented Jan 22, 2025

Explicitly state that in order to use SSO with existing LMS admin users, the newly created superuser in discovery must have the same username and email as the LMS user.

close #90

README.rst Outdated
Comment on lines 49 to 52
Then, you must log in with this user at http://discovery.local.openedx.io/admin.

Alternatively, you can log in with oauth2 using a pre-existing user created on the LMS/CMS by accessing
http(s)://discovery.<your lms host>/login. To do so, the proper domain names must exist and point to
the production server.
http(s)://discovery.<your lms host>/login. The user must be reassigned the ``superuser`` and ``is_staff`` status.
Copy link
Collaborator

@Faraz32123 Faraz32123 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docs/lines are already explaining it
at line 49: user should run above command and create a super user first in discovery.
at line 51: Only then, user'll be able to use SSO with LMS(if the above admin user with same username, email already exists in LMS) by accessing http(s)://discovery./login.

may be add some more clarity, as we don't need to reassign the superuser and is_staff status. We only need to make sure that both discovery and LMS have superusers with same credentials if user want to use SSO/oauth2 with LMS on discovery admin panel without entering username/password again.

@Faraz32123
Copy link
Collaborator

@mlabeeb03, can you edit the description of the PR and also add some information in commit message like what updates are made in the readme.

- Explicitly state that in order to use SSO with existing LMS admin users, the newly created superuser in discovery must have the same username and email as the LMS user.
@mlabeeb03 mlabeeb03 changed the title update: readme update docs: readme update Jan 22, 2025
@Faraz32123 Faraz32123 merged commit 4386c85 into overhangio:release Jan 22, 2025
2 checks passed
@mlabeeb03 mlabeeb03 deleted the update/readme branch January 22, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

SSO with LMS not working
2 participants