Add support for nil parameters #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throws an error if no params are defined when using named parameters, otherwise seems okay
- Remove extra _resolveNamedPlaceholders call from query - Apply several patches by github/testn (pending merge); refer to pull requests #1408, #1402, #1401, #1400 - Optimise query.row call - Cache lazy-evaluated field - Optimise string decoding - Avoid leaking TextRow/BinaryRow
- Throws a more specific error when receiving mismatch for column and value counts - Resolves error when final parameter is nil
Assigning the entries to an array first permits comparing the lengths and setting undefined entries as null
I'd like some control over incoming changes to fit our use-case, and patch-package doesn't quite fulfil our needs.
- '...?, ?, ?', {nil, nil, nil} will set all placeholders to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.