Add win32 path.toNamespacedPath and align rest of node:path with Node

src/bun.js/api/bun/spawn.zig

@@ -22,7 +22,7 @@ fn _getSystem() type {
 const Environment = bun.Environment;
 const system = _getSystem();
 
-const Maybe = JSC.Node.Maybe;
+const Maybe = JSC.Maybe;
 
 const fd_t = std.os.fd_t;
 const pid_t = std.os.pid_t;

src/bun.js/api/bun/subprocess.zig

@@ -699,7 +699,7 @@ pub const Subprocess = struct {
         return this.exit_code != null or this.signal_code != null;
     }
 
-    pub fn tryKill(this: *Subprocess, sig: i32) JSC.Node.Maybe(void) {
+    pub fn tryKill(this: *Subprocess, sig: i32) JSC.Maybe(void) {
         if (this.hasExited()) {
             return .{ .result = {} };
         }

src/bun.js/bindings/Path.cpp

@@ -122,9 +122,7 @@ JSC_DEFINE_HOST_FUNCTION(Path_functionResolve,
 JSC_DEFINE_HOST_FUNCTION(Path_functionToNamespacedPath,
     (JSC::JSGlobalObject * globalObject, JSC::CallFrame* callFrame))
 {
-    auto argCount = static_cast<uint16_t>(callFrame->argumentCount());
-    // TODO:
-    return JSC::JSValue::encode(callFrame->argument(0));
+    DEFINE_CALLBACK_FUNCTION_BODY(Bun__Path__toNamespacedPath);
 }
 
 static JSC::JSObject* createPath(JSGlobalObject* globalThis, bool isWindows)

src/bun.js/bindings/bindings.cpp

@@ -3316,6 +3316,10 @@ JSC__JSValue JSC__JSValue__jsDoubleNumber(double arg0)
 {
     return JSC::JSValue::encode(JSC::jsNumber(arg0));
 }
+JSC__JSValue JSC__JSValue__jsEmptyString(JSC__JSGlobalObject* arg0)
+{
+    return JSC::JSValue::encode(JSC::jsEmptyString(arg0->vm()));
+};
 JSC__JSValue JSC__JSValue__jsNull() { return JSC::JSValue::encode(JSC::jsNull()); };
 JSC__JSValue JSC__JSValue__jsNumberFromChar(unsigned char arg0)
 {

src/bun.js/bindings/bindings.zig

@@ -748,9 +748,9 @@ pub const ZigString = extern struct {
         if (is16Bit(&this)) {
             const buffer = this.toOwnedSlice(allocator) catch unreachable;
             return Slice{
+                .allocator = NullableAllocator.init(allocator),
                 .ptr = buffer.ptr,
                 .len = @as(u32, @truncate(buffer.len)),
-                .allocator = NullableAllocator.init(allocator),
             };
         }
 
@@ -3960,27 +3960,32 @@ pub const JSValue = enum(JSValueReprInt) {
         return null;
     }
 
-    pub fn jsNumber(number: anytype) JSValue {
-        return jsNumberWithType(@TypeOf(number), number);
+    pub inline fn jsBoolean(i: bool) JSValue {
+        return cppFn("jsBoolean", .{i});
+    }
+
+    pub fn jsDoubleNumber(i: f64) JSValue {
+        return cppFn("jsDoubleNumber", .{i});
+    }
+
+    pub inline fn jsEmptyString(globalThis: *JSGlobalObject) JSValue {
+        return cppFn("jsEmptyString", .{globalThis});
     }
 
     pub inline fn jsNull() JSValue {
         return JSValue.null;
     }
-    pub inline fn jsUndefined() JSValue {
-        return JSValue.undefined;
-    }
-    pub inline fn jsBoolean(i: bool) JSValue {
-        const out = cppFn("jsBoolean", .{i});
-        return out;
+
+    pub fn jsNumber(number: anytype) JSValue {
+        return jsNumberWithType(@TypeOf(number), number);
     }
 
-    pub fn jsTDZValue() JSValue {
+    pub inline fn jsTDZValue() JSValue {
         return cppFn("jsTDZValue", .{});
     }
 
-    pub fn jsDoubleNumber(i: f64) JSValue {
-        return cppFn("jsDoubleNumber", .{i});
+    pub inline fn jsUndefined() JSValue {
+        return JSValue.undefined;
     }
 
     pub fn className(this: JSValue, globalThis: *JSGlobalObject) ZigString {