Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for bun.lock #16585

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update docs for bun.lock #16585

merged 1 commit into from
Jan 22, 2025

Conversation

pfgithub
Copy link
Contributor

Updates docs for bun.lock being default

@robobun
Copy link

robobun commented Jan 22, 2025

Updated 6:15 PM PT - Jan 21st, 2025

@pfgithub, your commit ddd69e5 has 3 failures in #10332:


🧪   try this PR locally:

bunx bun-pr 16585

# Note: it does not load the lockfile, it just converts bun.lockb into a yarn.lock
# Note: it does not load the lockfile, it just converts bun.lock into a yarn.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change may be inaccurate but the rest lgtm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bun init -y
bun install --yarn
ls
  bun.lock
  yarn.lock

Seems accurate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bunfig option only makes --yarn default to on? ah my mistake then. assumed it might interact with bun bun.lockb in some way

@Jarred-Sumner Jarred-Sumner merged commit b0c5a76 into main Jan 22, 2025
47 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/update-docs-for-bunlock branch January 22, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants