Don't require AWS credentials #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works here as well. |
|
Sorry for late response. |
|
I just released new version. |
|
Very cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the AWS JavaScript SDK, credentials are automatically searched for: https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/setting-credentials-node.html
When running on AWS with an IAM Role and setting fake
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEY, the container doesn't start as the SDK tries to use those before falling back to searching for other credentials. Even trying to useAWS_PROFILEhas the same effect.AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYare not required for running.Fixes #31