Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override controler toleration #804

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Feb 20, 2024

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
#803
What testing is done?

@outscale-mdr
Copy link
Contributor

Hello @sebglon,

Thank you for the contribution. The PR is indeed to avoid deploying on nodes that have these tolerations:

  • CriticalAddonsOnly
  • *:NoExecute

Tests are executed here (https://github.com/outscale/osc-bsu-csi-driver/actions/runs/7986476470). Will merge when they pass (but they should be)

@outscale-mdr outscale-mdr self-requested a review February 21, 2024 09:51
@outscale-mdr outscale-mdr merged commit 666e4c4 into outscale:master Feb 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants