Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd packages in minimal installation #1965

Open
mikhailnov opened this issue Dec 22, 2019 · 2 comments · May be fixed by #1974
Open

odd packages in minimal installation #1965

mikhailnov opened this issue Dec 22, 2019 · 2 comments · May be fixed by #1974

Comments

@mikhailnov
Copy link

I ran bash vst-install.sh --nginx no --apache no --phpfpm no --named yes --remi yes --vsftpd no --proftpd no --iptables no --fail2ban no --quota no --exim no --dovecot no --spamassassin no --clamav no --softaculous no --mysql no --postgresql no in container with minimal Ubuntu 18.04 to use it only as a DNS slave.

But nginx repos were added, nginx, roundcube etc. packages were installed. They are not needed and were explicitly disable by cli arguements.

@Skamasle
Copy link
Collaborator

Skamasle commented Jan 28, 2020

Hi

I reproduce part of issue in debian, in may case nginx was not installed but roundcube and phpmyadmin yes.

Why ?

There is nothing to exclude phpmyadmin / roundcube from installer

--phpfpm no

Just not install php-fpm

There is no exclude for phpmyadmin / roundube / php*

With your command vesta installer still install next packages

  php
        php-common php-cgi  php-curl   awstats
        webalizer   bind9 
            roundcube-core
        roundcube-mysql roundcube-plugins  
            phpmyadmin mc
        flex whois rssh git idn zip sudo bc ftp lsof ntpdate rrdtool quota
        e2fslibs bsdutils e2fsprogs curl imagemagick  dnsutils
        bsdmainutils cron vesta vesta-nginx vesta-php expect 
        unrar-free vim-common vesta-ioncube  net-tools unzip

So installer need argument like --php-deps no

And add something like:

if [ "$php" = 'no' ]; then
    software=$(echo "$software" | sed -e 's/php //')
    software=$(echo "$software" | sed -e 's/php-common//')
    software=$(echo "$software" | sed -e 's/php-cgi//')
    software=$(echo "$software" | sed -e 's/php-curl//')
    software=$(echo "$software" | sed -e 's/roundcube-core//')
    software=$(echo "$software" | sed -e 's/roundcube-mysql//')
    software=$(echo "$software" | sed -e 's/roundcube-plugins//')
    software=$(echo "$software" | sed -e 's/php[Mm]y[Aa]dmin//')
    software=$(echo "$software" | sed -e 's/awstats//')
    software=$(echo "$software" | sed -e 's/webalizer//')
fi

So if we not need apache / nginx for what we need phpmyadmin , roundcube and orthers, and all that install mysql-client and some orther dependencies.

@Skamasle
Copy link
Collaborator

Skamasle commented Jan 28, 2020

I see this better and phpmyadmin was excluded if mysql is not selected

But in incorrect way because sed looking for capital letters

So, that need be fixed, and we can add roundcube exclusion if dovecot not installed

Edit---

So in debian 9 works apt-get install phpmyadmin and in debian 8 works apt-get install phpMyAdmin ? so need add sed twice to process $software

Edit 2--

Can fixed with:

software=$(echo "$software" | sed -e 's/php[Mm]y[Aa]dmin//')

Skamasle added a commit that referenced this issue Jan 28, 2020
PHPMYADMIN need two exclustions in debian 9 and 10 was defined diferent

If we not have apache instaled and not select php-fpm to use nginx + php-fpm we cant use phpmyadmin, php, roundcube, awstats and webanalizer so remove all

This will fix #1965 I need check ubuntu installer and see if have similar problem
@Skamasle Skamasle linked a pull request Jan 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants