Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source/target masks #603

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Remove source/target masks #603

merged 5 commits into from
Dec 3, 2024

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Dec 2, 2024

No description provided.

@michalk8 michalk8 added the misc label Dec 2, 2024
@michalk8 michalk8 self-assigned this Dec 2, 2024
@michalk8 michalk8 requested a review from marcocuturi December 2, 2024 14:19
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michalk8 michalk8 marked this pull request as ready for review December 2, 2024 14:22
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 79.01235% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (04e5abb) to head (4a89427).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ott/geometry/geometry.py 73.52% 5 Missing and 4 partials ⚠️
src/ott/geometry/low_rank.py 66.66% 2 Missing and 1 partial ⚠️
src/ott/geometry/pointcloud.py 87.50% 2 Missing and 1 partial ⚠️
src/ott/utils.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   88.15%   87.91%   -0.24%     
==========================================
  Files          74       74              
  Lines        7753     7657      -96     
  Branches      542      533       -9     
==========================================
- Hits         6835     6732     -103     
- Misses        777      783       +6     
- Partials      141      142       +1     
Files with missing lines Coverage Δ
src/ott/geometry/grid.py 96.21% <ø> (-0.06%) ⬇️
src/ott/problems/quadratic/gw_barycenter.py 89.81% <100.00%> (-0.19%) ⬇️
src/ott/solvers/linear/continuous_barycenter.py 94.11% <ø> (ø)
src/ott/solvers/quadratic/gw_barycenter.py 93.20% <100.00%> (ø)
src/ott/tools/k_means.py 96.25% <100.00%> (ø)
src/ott/tools/segment_sinkhorn.py 100.00% <ø> (ø)
src/ott/tools/sinkhorn_divergence.py 94.18% <ø> (-0.14%) ⬇️
src/ott/utils.py 96.22% <50.00%> (-1.20%) ⬇️
src/ott/geometry/low_rank.py 95.70% <66.66%> (-1.04%) ⬇️
src/ott/geometry/pointcloud.py 96.50% <87.50%> (+1.06%) ⬆️
... and 1 more

@michalk8 michalk8 merged commit 690b1ae into main Dec 3, 2024
11 of 13 checks passed
@michalk8 michalk8 deleted the misc/remove-masks branch December 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants