correct convergence criterion for GW #566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entropic GW convergence was testing
This is wrong, because
out.linear_convergence
was allocated by default a vector ofmax_iterations
values set at-1
. Therefore, if the solver stops beforemax_iterations
, the remaining entries were set at-1
and the bool was necessarilyFalse
(note that given the first test above, when stopping atmax_iterations
, the value was alsoFalse
).The flag was therefore always
False
.The modification proposes to populate instead with
Nan
values and check thatjnp.nanmean
is1.0
.