add MMSinkhorn solver #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 91.34% 91.38% +0.03%
==========================================
Files 68 69 +1
Lines 7083 7242 +159
Branches 991 1019 +28
==========================================
+ Hits 6470 6618 +148
- Misses 463 472 +9
- Partials 150 152 +2
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
michalk8
requested changes
Jun 20, 2024
michalk8
requested changes
Jun 20, 2024
michalk8
approved these changes
Jun 21, 2024
|
Looks great @marcocuturi , merging now! |
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* add MMSinkhorn solver * more tests and properties * docs * correct docs bug * add docstrings + test multiple costs + handle danskin properly * spelling * switch back to point cloud * Fix jax>=0.4.30 CUDA installation on the CI * Increase mem for `test_sinkhorn_online_memory_jit` * spell * fix * fix error tolerances * add tutorial * typo * typos * typo * polymatching * pydocs * spin off MMSinkhorn from SInkhorn, add back `norm_error` * typos * typo * typo * incorporate feedback + differentiability * typo * Fix minor pet-peeves * Link to classes in the docs --------- Co-authored-by: Michal Klein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental code to compute the multimarginal Sinkhorn algorithm, as described in Algorithm 1 of https://arxiv.org/abs/2405.19532v1
Largely based on the
Sinkhorntemplate, but simpler (no definition of MM problems, not unbalanced).