Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h-transform for TI costs #525

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Add h-transform for TI costs #525

merged 1 commit into from
Apr 27, 2024

Conversation

michalk8
Copy link
Collaborator

TODO:

  • tests

@michalk8 michalk8 self-assigned this Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (c37f0c4) to head (4dbd571).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   91.04%   90.93%   -0.11%     
==========================================
  Files          68       68              
  Lines        7054     7063       +9     
  Branches      998      998              
==========================================
+ Hits         6422     6423       +1     
- Misses        478      486       +8     
  Partials      154      154              
Files Coverage Δ
src/ott/geometry/costs.py 90.95% <11.11%> (-1.66%) ⬇️

@marcocuturi
Copy link
Contributor

LGTM, thanks!

Note for self: maybe we should also add an empty template method in geometries, to define the c_transform, overriding it with h_transform for TICosts

@marcocuturi marcocuturi merged commit 261b730 into main Apr 27, 2024
13 checks passed
@marcocuturi
Copy link
Contributor

(apologies, hadn't realized the tests were coming (>_<;)

please add them in another PR

@michalk8 michalk8 mentioned this pull request Apr 29, 2024
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8 michalk8 deleted the feature/ti-h-legendre branch July 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants