-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DetectOrientationScript method #299
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 71.47% 69.25% -2.23%
==========================================
Files 1 1
Lines 284 322 +38
==========================================
+ Hits 203 223 +20
- Misses 67 79 +12
- Partials 14 20 +6 ☔ View full report in Codecov by Sentry. |
This has been helpful to me 🙏. Worth mentioning perhaps that using this requires an optional (in Fedora Linux at least) package that needs to be installed ( |
Alpine test is failing. (please ignore vagrant) |
Hi @otiai10, thanks for your review! I've fixed the issue, so the alpine test should pass now. Could you review again or merge if all's good? Thanks! |
I fixed clearlinux case. |
This exposes the DetectOrientationScript method. I've used this for quite some time privately and would like to bring this upstream.