Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DetectOrientationScript method #299

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

joelrose
Copy link
Contributor

@joelrose joelrose commented Jan 17, 2024

This exposes the DetectOrientationScript method. I've used this for quite some time privately and would like to bring this upstream.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 69.25%. Comparing base (d85513d) to head (29d25d8).
Report is 7 commits behind head on main.

Files Patch % Lines
client.go 52.63% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   71.47%   69.25%   -2.23%     
==========================================
  Files           1        1              
  Lines         284      322      +38     
==========================================
+ Hits          203      223      +20     
- Misses         67       79      +12     
- Partials       14       20       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiojr
Copy link

rubiojr commented Feb 29, 2024

This has been helpful to me 🙏. Worth mentioning perhaps that using this requires an optional (in Fedora Linux at least) package that needs to be installed (tesseract-osd), or you'll get a failed to initialize TessBaseAPI with code -1 runtime error, which was confusing.

@otiai10
Copy link
Owner

otiai10 commented Mar 8, 2024

Alpine test is failing. (please ignore vagrant)

@joelrose joelrose requested a review from otiai10 March 14, 2024 22:48
@joelrose
Copy link
Contributor Author

Hi @otiai10, thanks for your review! I've fixed the issue, so the alpine test should pass now. Could you review again or merge if all's good? Thanks!

@otiai10
Copy link
Owner

otiai10 commented Jun 21, 2024

I fixed clearlinux case.

@otiai10 otiai10 merged commit 3d69987 into otiai10:main Jun 21, 2024
13 of 16 checks passed
@otiai10
Copy link
Owner

otiai10 commented Jun 21, 2024

Sorry I misunderstood that I fixed your issue by #309

I revert this PR by #310, so please reopen this PR with all test case green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants