Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Refactor/tests snapshots #207

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Refactor/tests snapshots #207

merged 2 commits into from
Jul 13, 2018

Conversation

eve-horne
Copy link

Updates Made

Added tests to support "onFilterUpdate" for CombinedFilter.tsx
Added tests to support FilterLink.tsx
Added tests to support "toShortString" variant of "gradeCaseToString" for GradeLevels.tsx
Added "id" field to Filter Mocks

Contributing developer checklist

  • I've updated source branch with the latest changes from dev.
  • I've added/changed unit tests for components with functionality.
  • I've added/updated storybook for any component that I've changed.
  • I've reviewed each jsdoc header in regards to the changes that I've made and updated them.

Reviewing developer checklist

  • I've pulled this branch to my local machine.
  • I've inspected the changes on storybook.
  • I've run the test suite and all tests have passed

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 77.525% when pulling 38cd96a on refactor/tests-snapshots into f6f1921 on dev.

Copy link

@tnoelcke tnoelcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you improved our coverage my 1.2% nice work!

@tnoelcke tnoelcke merged commit 767dfb4 into dev Jul 13, 2018
@cass-osu
Copy link

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants