-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: Add a hidden option to ostree admin kargs edit-in-place
to update all existing deployments in place
#2617
Comments
ostree admin kargs edit-in-place --append-if-missing=rw
to update all existing deployments in placeostree admin kargs edit-in-place
to update all existing deployments in place
My main uncertainty here is whether this is a new subcommand or simply a flag. The current proposal is a subcommand, but I think a flag makes more sense because it can apply to all other operations (delete/add) etc. In the subcommand version:
In the flag version:
|
@cgwalters we'd like to scope this logic into an hidden subcommand, solving the immediate needs of Silverblue only. This task has two odd semantic requirements (in-place changes; tweaking all the deployments) which we'd like not to advertise too much. For future public kargs verbs we'd like to stick to something similar to rpm-ostree behavior, which creates new deployments and does not touch inactive ones. In that regard, future non-hidden/documented subcommands may look like this:
Flags like |
Both make sense, the flag version can better reuse the code, and subcommand version make the logic more specific. @travier @cgwalters @lucab @jlebon , WDYT? |
Sounds good to me! |
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617 This will not add duplicate key, if there is `TESTARG=VAL1` in the kernel arguments, `--append-if-missing=TESTARG=VAL2` will be ignored.
update all existing deployments in place Example: $ sudo ostree admin kargs edit-in-place --append-if-missing=rw See ostreedev#2617 This will not add duplicate key, if there is `TESTARG=VAL1` in the kernel arguments, `--append-if-missing=TESTARG=VAL2` will be ignored.
Close this refer to #2639 |
Describe the enhancement
Add a hidden option to
ostree admin kargs edit-in-place
to update all existing deployments in place.Example:
$ sudo ostree admin kargs edit-in-place --append-if-missing=rw
This would be useful for: https://fedoraproject.org/wiki/Changes/Silverblue_Kinoite_readonly_sysroot
The text was updated successfully, but these errors were encountered: