Fixed duplicate timestamps causing pagination test failure #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-hossam28
changed the title
ostafen
reviewed
Sep 20, 2024
ostafen
reviewed
Sep 20, 2024
db_test.go
Outdated
| // Old code that caused duplicates: | ||
| // doc.Set("timestamp", time.Now()) | ||
|
|
||
| // New code to ensure unique timestamps: |
There was a problem hiding this comment.
This comment makes sense, but there is no need to mention about what "old code" was doing
There was a problem hiding this comment.
You can leave this one, but rephrase it to not mention "old code"
ostafen
reviewed
Sep 20, 2024
ostafen
reviewed
Sep 20, 2024
|
Thank you @ostafen for your efforts too, I will resolve them. |
…r review feedback.
|
@ostafen, I have removed the unnecessary comments and the checkUniqueTimestamps function as suggested. |
ostafen
reviewed
Sep 21, 2024
db_test.go
Outdated
| @@ -1507,7 +1507,11 @@ func TestPagedQueryUsingIndex(t *testing.T) { | |||
| n := 10003 | |||
| for i := 0; i < n; i++ { | |||
| doc := d.NewDocument() | |||
| doc.Set("timestamp", time.Now()) | |||
|
|
|||
| // doc.Set("timestamp", time.Now()) | |||
|
Thank you @ostafen for your feedback, i updated the comments. |
ostafen
approved these changes
Sep 21, 2024
|
Looks good now, thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.