Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Error when both HLS and HTTP-TS enabled. #3400

Merged

Conversation

chundonglinlin
Copy link
Member

If enable HLS and HTTP-TS, SRS can't identify the protocol(HLS or HTTP-TS). So when SRS start, we detect the conflict for HLS and HTTP-TS.

Test1

vhost __defaultVhost__ {
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }
    hls {
        enabled         on;
        hls_path        ./objs/nginx/html;
        hls_fragment    10;
        hls_window      60;
    }
}

Test2

vhost __defaultVhost__ {
    http_remux {
        enabled     off;
        mount       [vhost]/[app]/[stream].ts;
    }
    hls {
        enabled         on;
        hls_path        ./objs/nginx/html;
        hls_fragment    10;
        hls_window      60;
    }
}

Test3

vhost __defaultVhost__ {
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }
    hls {
        enabled         off;
        hls_path        ./objs/nginx/html;
        hls_fragment    10;
        hls_window      60;
    }
}

Test4

vhost __defaultVhost__ {
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].flv;
    }
}

Test5

vhost __defaultVhost__ {
    http_remux {
        enabled     off;
        mount       [vhost]/[app]/[stream].ts;
    }
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].flv;
    }
}

@chundonglinlin chundonglinlin force-pushed the feature/detect-conflict-hls-remux branch from 1c2c1a2 to 49430dd Compare February 7, 2023 14:04
@chundonglinlin chundonglinlin force-pushed the feature/detect-conflict-hls-remux branch from 49430dd to f2ccac1 Compare February 7, 2023 14:06
@winlinvip winlinvip changed the title Config: Should return error when both HLS and HTTP-TS are enabled.(#3391) Config: Should error when both HLS and HTTP-TS enabled.(#3391) Feb 8, 2023
@winlinvip winlinvip linked an issue Feb 8, 2023 that may be closed by this pull request
@winlinvip winlinvip changed the title Config: Should error when both HLS and HTTP-TS enabled.(#3391) Config: Error when both HLS and HTTP-TS enabled. Feb 8, 2023
@winlinvip winlinvip merged commit 5b001fe into ossrs:develop Feb 8, 2023
winlinvip added a commit that referenced this pull request Feb 8, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should return error when both HLS and HTTP-TS are enabled
3 participants