🌱 GitLab: Add log message #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3319 +/- ##
===========================================
- Coverage 72.83% 61.46% -11.37%
===========================================
Files 173 173
Lines 12686 12694 +8
===========================================
- Hits 9240 7803 -1437
- Misses 2941 4464 +1523
+ Partials 505 427 -78 |
There was a problem hiding this comment.
Can we add a TODO comment with tracking issue?
Note: this can run multiple times, but not sure pushing the error deeper can be done as easily as right here
SCORECARD_EXPERIMENTAL=1 go run main.go --repo gitlab.com/ossf-test/scorecard-archived-project --commit 240e1fbc4c4ea614527c59f453bf54107d8833f2
...
Scorecard may be missing merge requests when running on non-HEAD of a GitLab repo. Code-Review scores may be lower.
Scorecard may be missing merge requests when running on non-HEAD of a GitLab repo. Code-Review scores may be lower.
Scorecard may be missing merge requests when running on non-HEAD of a GitLab repo. Code-Review scores may be lower.
Scorecard may be missing merge requests when running on non-HEAD of a GitLab repo. Code-Review scores may be lower.
...
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
* log once * todo Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Jul 28, 2023
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* log msg Signed-off-by: Raghav Kaul <[email protected]> * address pr comments * log once * todo Signed-off-by: Raghav Kaul <[email protected]> --------- Signed-off-by: Raghav Kaul <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds log message when GitLab is running on non-HEAD that scores may be inaccurate.
Which issue(s) this PR fixes
Temporary warning #3193 to unblock release.