Skip to content

support full paths to world files #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Conversation

M1chaelM
Copy link
Collaborator

This provides the quickest fix to issue #680 by extracting a normalized world name from any incoming path, and adding a few likely names to our list of worlds that we recognize and create bridges for. It doesn't fix the deeper conceptual problems described in #680.

To test:

Run a task using an absolute path:

ros2 launch vrx_gz competition.launch.py world:=`pwd`/src/vrx/vrx_gz/worlds/stationkeeping_task.sdf

in another terminal run

ros2 topic list

and verify that you see the correct list of topics. Next, rename one of our task worlds to one of the generic names we use in our testing, and check the topics again to verify that it still works:

cp `pwd`/src/vrx/vrx_gz/worlds/stationkeeping_task.sdf stationkeeping0.sdf
ros2 launch vrx_gz competition.launch.py world:=`pwd`/stationkeeping0.sdf

Bonus: Gazebo will no longer crash if the user accidentally includes the world file extension.

@M1chaelM M1chaelM requested a review from caguero June 23, 2023 22:11
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, including running the acoustic_perception_task world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants