Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use no-install-recommends #357

Merged
merged 7 commits into from
Apr 5, 2020
Merged

use no-install-recommends #357

merged 7 commits into from
Apr 5, 2020

Conversation

mikaelarguedas
Copy link
Contributor

Generated from osrf/docker_templates#82

@mikaelarguedas
Copy link
Contributor Author

all ci passed as of 1145040

Reverted testing commits edfd6f1 and 6fd5fe8 for final review

@ruffsl
Copy link
Member

ruffsl commented Mar 7, 2020

Ok. I've manually tested at least the eloquent tags in three ways:

REPOSITORY    TAG        IMAGE ID        CREATED         SIZE
my/ros        runner     66c8112b2fb6    2 seconds ago   654MB
my/ros        builder    6b500239d0d6    9 seconds ago   859MB
$ docker run -it --rm my/ros:app 
[INFO] [launch]: All log files can be found below /root/.ros/log/2020-03-07-21-06-32-377510-6f89e4f76819-1
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [talker-1]: process started with pid [239]
[INFO] [listener-2]: process started with pid [240]
[talker-1] [INFO] [talker]: Publishing: 'Hello World: 1'
[listener-2] [INFO] [listener]: I heard: [Hello World: 1]
[talker-1] [INFO] [talker]: Publishing: 'Hello World: 2'
[listener-2] [INFO] [listener]: I heard: [Hello World: 2]

All worked fine as expected. I'd say give folks on discourse a heads up on this PR a week before merging to let anyone else make suggestions or report corner cases.

Signed-off-by: Mikael Arguedas <[email protected]>
@mikaelarguedas mikaelarguedas force-pushed the no-install-recommends branch from 07c6d01 to 1eb62fe Compare April 5, 2020 13:47
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants