Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cardzone Group, and the Brands it operates #9785

Closed
6 tasks done
ClarSco opened this issue Aug 10, 2024 · 6 comments
Closed
6 tasks done

Add Cardzone Group, and the Brands it operates #9785

ClarSco opened this issue Aug 10, 2024 · 6 comments
Assignees
Labels
add brand Actionable - add a brand to the index

Comments

@ClarSco
Copy link
Contributor

ClarSco commented Aug 10, 2024

According to their website, Cardzone Ltd. owns/operates 141 stores across the UK under the following brands:

  • Cardzone (60 stores)
  • Mooch (18 stores)
  • Paper Kisses (17 stores)
  • Hallmark (20 stores)
  • Yankee Candle (12 stores)
  • Card Centre (14 stores)

Of these, only Hallmark and Yankee Candles have entries in the NSI.

@ClarSco
Copy link
Contributor Author

ClarSco commented Aug 10, 2024

Relevant Wikidata Items:

Relevant Wikipedia articles:

@Snowysauce
Copy link
Collaborator

I've opened a pull request to add the Cardzone brand to NSI as it easily meets the suggested inclusion criteria. As you mentioned, Hallmark and Yankee Candle are already in the NSI, and both are also already available for tagging in the UK.

That leaves the Mooch, Paper Kisses, and Card Centre brands, which may not have enough locations to be included in the NSI. I'll defer to the opinions of the more established maintainers when it comes to that topic.

As for Cardzone Group (the operator), adding it to the NSI in such a way that would address this issue would require (to my knowledge) adding two new categories that don't currently exist in the code: operators/shop/gift and operators/shop/candles. Again, I'll defer to the opinions of the more established maintainers as to whether these should be added (and whether my understanding of the code is correct).

@Snowysauce Snowysauce added new category Add support for a new kind of feature add operator Actionable - add an operator to the index labels Aug 13, 2024
@bhousel
Copy link
Member

bhousel commented Aug 13, 2024

This sounds like it would cause the same issues as #9716
If we already have these as brands we shouldn't also have an entry under the operators tree for "Cardzone Group" as the operator.

@Snowysauce
Copy link
Collaborator

If I'm interpreting the comments at #9716 correctly, the plugins/editors using the NSI prioritize matching for brands prior to matching for operators, and only attempt to match for operators if there were no matching brands? It makes sense and I agree that this is the correct prioritization, but I didn't know that. For the OP, I guess that leaves three options:

  • having Mooch, Paper Kisses, and Card Centre added as brands, which depends on another maintainer deeming them individually notable
  • leaving the three brands out, and creating a "Cardzone Group" operator entry that would only match said brands (collectively 49 stores per the OP)
  • the status quo: Cardzone, Hallmark, Yankee Candle in the NSI; Mooch, Paper Kisses, and Card Centre not in; no operator entry for Cardzone Group

Notes for the OP on option 2: either the Cardzone brand or the Cardzone Group operator would need a separate Wikidata item from Q123019897 as the npm operations used to build the NSI will produce a warning if the same QID is used in both the brand and operator trees in the same category (e.g., brands/shop/gift and operators/shop/gift).

@bhousel
Copy link
Member

bhousel commented Aug 14, 2024

If I'm interpreting the comments at #9716 correctly, the plugins/editors using the NSI prioritize matching for brands prior to matching for operators, and only attempt to match for operators if there were no matching brands?

Sort of - yes the matching behavior is kind of confusing and the code is simpler than people think.

I think people believe that the code works like:
"If I see name=Hallmark I can suggest brand:wikidata=Q1521910
AND if I see operator=Cardzone I can suggest operator:wikidata=Q123019897"

The problem is that there is no ability to do AND, or chain rules together like that.
It just does one tag match and suggests more correct tags based on that.

So, if all the Hallmarks really are operated by Cardzone, you can just add those tags to the existing brand/shop/gift.json Hallmark item.

Operator is also tricky in OSM for brands that operate under the franchise model. So I don't know whether all Hallmarks really are operated by Cardzone, or whether they are operated by franchisees.

In any case..

  • Tagging brand=Hallmark and brand:wikidata=Q1521910 is extremely useful to tie all the Hallmarks together under that common brand, and gives data consumers a link to Wikidata where they can find out all kinds of other information about Hallmark (maybe including their business connection to Cardzone)
  • Tagging operator=Cardzone and operator:wikidata=Q123019897 on each Hallmark is.. Maybe interesting to someone? Probably not wrong? I've never understood who cares about this tag.

@UKChris-osm
Copy link
Collaborator

UKChris-osm commented Aug 17, 2024

I don't think we need to worry about the operator in this case at all, and focus purely on the brands individually. I'd be happy for the remaining three brands to be added as they are, as while they may not have a large number of stores, I think they still have enough value in them to be added individually, and more stores may be opened at a later date.

UKChris-osm added a commit that referenced this issue Aug 17, 2024
Added Mooch (gb) to gift.json #9785
@UKChris-osm UKChris-osm added add brand Actionable - add a brand to the index and removed new category Add support for a new kind of feature add operator Actionable - add an operator to the index labels Aug 17, 2024
UKChris-osm added a commit that referenced this issue Aug 17, 2024
Added Paper Kisses (gb) to gift.json #9785
UKChris-osm added a commit that referenced this issue Aug 17, 2024
Added Card Centre (gb) to gift.json #9785
@UKChris-osm UKChris-osm self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Development

No branches or pull requests

4 participants