-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cardzone Group, and the Brands it operates #9785
Comments
Relevant Wikidata Items:
Relevant Wikipedia articles:
|
I've opened a pull request to add the Cardzone brand to NSI as it easily meets the suggested inclusion criteria. As you mentioned, Hallmark and Yankee Candle are already in the NSI, and both are also already available for tagging in the UK. That leaves the Mooch, Paper Kisses, and Card Centre brands, which may not have enough locations to be included in the NSI. I'll defer to the opinions of the more established maintainers when it comes to that topic. As for Cardzone Group (the operator), adding it to the NSI in such a way that would address this issue would require (to my knowledge) adding two new categories that don't currently exist in the code: |
This sounds like it would cause the same issues as #9716 |
If I'm interpreting the comments at #9716 correctly, the plugins/editors using the NSI prioritize matching for brands prior to matching for operators, and only attempt to match for operators if there were no matching brands? It makes sense and I agree that this is the correct prioritization, but I didn't know that. For the OP, I guess that leaves three options:
Notes for the OP on option 2: either the Cardzone brand or the Cardzone Group operator would need a separate Wikidata item from Q123019897 as the |
Sort of - yes the matching behavior is kind of confusing and the code is simpler than people think. I think people believe that the code works like: The problem is that there is no ability to do AND, or chain rules together like that. So, if all the Hallmarks really are operated by Cardzone, you can just add those tags to the existing Operator is also tricky in OSM for brands that operate under the franchise model. So I don't know whether all Hallmarks really are operated by Cardzone, or whether they are operated by franchisees. In any case..
|
I don't think we need to worry about the |
Added Mooch (gb) to gift.json #9785
Added Paper Kisses (gb) to gift.json #9785
Added Card Centre (gb) to gift.json #9785
According to their website, Cardzone Ltd. owns/operates 141 stores across the UK under the following brands:
Of these, only Hallmark and Yankee Candles have entries in the NSI.
The text was updated successfully, but these errors were encountered: