-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new category for traffic signs #8225
Comments
I’m not quite sure what this is asking for? Are you referring to adding brand / operator tags for traffic signs, which I would suggest is unnecessary considering how many signs exist, and which would likely already be region specific by default. Or is this about Country specific traffic icons appearing in iD when editing? If so, I think that would be out of scope for the NSI, but would work well as a new repository, and could mimic how the NSI works with Country specific presets being available. I think the comment from @bhousel was about how country-coder would make the NSI better, and not about adding traffic signs making the NSI better. I see the former maintainer of iD @quincylvania also thought a new repository would be a good way to make traffic signs available. If I have misunderstood this issue, my apologies. |
"An item for every traffic sign" is a thing that we could add here to name-suggestion-index under its own tree, but it would make sense to do ideditor/nsi-collector#2 first, so that we can collect the data from Wikidata where it already exists. (Road routes #4768 are like this too) The chatter on that other issue was from 2019 in an issue in the iD repo - back then I was the maintainer and iD did not have country specific presets. Since then, we added support for specific presets using the Country Coder and |
As with road and bicycle route As with flags (#5982) and denominations (openstreetmap/id-tagging-schema#254), the preset names need to be localizable. Many countries officially speak multiple languages that have different words for the same exact sign, regardless of the location within the country. These aren’t proper nouns, so the name of a sign in another language really wouldn’t be understandable or searchable (except maybe for “Stop”). |
Here is another project that aimed to collect traffic sign, but looks like only contain US data currently. |
Yes, looks like @arch0345 started indexing Wikidata items about MUTCD signs, of which there are very few. Regardless of the repository, I think it would be worthwhile to automate the creation of indices like this, with the manual aspect being limited to OSM tagging at most. That could include mass-adding items about these signs to Wikidata. |
Can the identifying tagging be based on a link tag like |
|
Can you connect the dots for me? I'm not seeing how I'd actually accomplish this. e.g. I go to I see ![]() Ok, so The List of IDs by country table has some resources, but also a lot seems missing. I follow the links there to other places, but neither of these pages has anything about Compare this to flags, where there's a very clear path from |
First of all, I agree, there are still a lot of gaps. Ultimately, an editor needs three things to correspond to a given standard traffic sign:
One option for associating a traffic sign with a Wikimedia Commons image would be to rely on pattern matching. Unlike for brand logos, the road editors on Commons insist on consistent file naming whenever possible. So the UK’s sign 956 is located at Unfortunately, all Commons can provide is the image. For the name of each sign, we can build out Wikidata’s coverage of sign items and use their labels, as I alluded to above and as OSM Americana has successfully done with road networks. Or we can maintain our own tables of sign names in this repository and solicit translations through a TMS such as Translatewiki.net or Transifex. Either way, I don’t think we need to add any Wikidata QIDs directly to OSM, because the lookup table between official sign codes (which are tagged) and Wikidata QIDs would be a straightforward SPARQL query; the index could simply cache the results. For the other OSM tags that indicate the sign’s parameters, such as |
If traffic signs become part of the NSI, would this make the dataset a lot larger than it is now? |
Yeah, sorry to say this just sounds too hard. The schema for traffic sign tagging is too chaotic, we'd need to change a bunch of things about how NSI works in order to support it. You've talked me out of it 😁 |
Coming from openstreetmap/id-tagging-schema#11.
I think that a good idea is to have them separated in files for each country (
data/traffic_signs/DE.json
for example).The suggested schema also looks ok to me.
description
is the string that is shown to the end user, maybe we can rename it toname
ordisplayName
. There could be additional fields for some signs (maxweight
,maxspeed
, maxheight` etc.).I assume that it is possible to add
locationSet
to each item for thedist
folder during build time.The text was updated successfully, but these errors were encountered: