Add shields for New York parkways #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
The changes look good to me on a technical level and as someone who likes initialisms a little too much.
It would be great if we could get some quick feedback from a local. I think there were some strong feelings about how to tag these routes uniquely. Fortunately, this PR doesn’t actually rely on any keys other than network and name, which I’ve been viewing as a stopgap until we can get access to short_name or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shields for
US:NY:ParkwayandUS:NY:Parkway:NYCnetworks.Still missing are shields for parkways of Long Island and the Palisades Interstate Parkway Commission, because consistent tagging for these routes doesn't seem to have solidified yet.