Openlayers popup plugin pan map fix #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZakarFin
reviewed
Mar 29, 2018
| Object.keys(posClasses).forEach(function (pos){ | ||
| if (positioning === posClasses[pos]){ | ||
| positionX = positioning.split("-")[1]; | ||
| positionY = positioning.split("-")[0]; |
There was a problem hiding this comment.
Split once and take the results:
var popupDirection = positioning.split("-");
positionY = popupDirection[0];
positionX = popupDirection[1];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_panMapToShowPopup is used to pan map if infobox isn't entirely in the viewport (screen). If map is moving or ShowInfoBoxRequest's given position (lonlat) isn't in the current viewport, pixels for pan might be calculated wrongly. Now map pan is done only if popups position (lonlat) is in the current viewport. If you want to show popup outside current viewport, you have to make mapmoverequest first.
Also pixels calculations for pan map is fixed. Now supported ol.OverlayPositionings are calculated correctly. Before _panMapToShowPopup presumed that overlay's positioning is always 'top-left' (point's location) -> popup is rendered right and down from location. Now if ol.OverlayPositioning isn't defined ('no-position-info') -> 'top-left' positioning is used for calculations.