-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document vs Oembed / Instagram blocked #357
Comments
Hello. The way Oembed is detected is by priorizing the links found in the document and then the |
Ok, I understand. Now we've an issue with instagram. |
Mmm, I see. Perhaps it's because instagram detects too many requests from this ip? |
Yeah, that's the same issue I had. |
I made some changes to check the oembed endpoint not only with the final url, but also with the inital url and seems to work fine. |
Any chance this could be implemented in version 3 as well ? Update for anyone using version 3. @oscarotero , Is there any way to use a custom oembed Provider instead? |
New versions released with fixes for v4 and v3 |
|
Hey @zwan2, I think this is due to a "not registered" URL pattern for "instagr.am" -> https://github.com/oscarotero/Embed/blob/v3.x/src/Providers/OEmbed/Instagram.php#L10 |
There is a similar case for instagram TV, it's not matching the pattern and returning the login page, Embed v3.4 e.g https://www.instagram.com/tv/CC8AXWhgm_c/?utm_source=ig_web_copy_link P.S awesome library, thanks |
Is it possible for Instagram and Facebook some how force the lib to use the original url and not use any redirect ? |
Hi,
I'm using v4 for resolving our embeds.
Mainly (probably only) we are using embeds which does provide an oembed endpoint.
So we've a big overhead by first getting the main document of that "url".
https://github.com/oscarotero/Embed/blob/master/src/Embed.php#L23-L24
I think it'll be a big benefit to first check if that url does provide an oembed endpoint (
detectEndpointFromProviders
) and if so to only query that specific api endpoint.Is there any build in way that I'm missing?
Regards
The text was updated successfully, but these errors were encountered: