Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve show for generic characters #99

Merged
merged 1 commit into from
Jul 24, 2024
Merged

improve show for generic characters #99

merged 1 commit into from
Jul 24, 2024

Conversation

fingolfin
Copy link
Member

fix a typo, and omit the paramter list if it is empty

@fingolfin fingolfin requested a review from SoongNoonien July 24, 2024 16:22
fix a typo, and omit the paramter list if it is empty
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (7190d42) to head (37770df).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files          10       10           
  Lines         908      908           
=======================================
  Hits          638      638           
  Misses        270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SoongNoonien SoongNoonien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I did print the parameters even if they are empty...

@SoongNoonien SoongNoonien merged commit 7ba0b8f into master Jul 24, 2024
7 of 8 checks passed
@fingolfin fingolfin deleted the mh/typo-tweak branch July 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants