Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved printing of Cyclotomic #53

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

SoongNoonien
Copy link
Member

I tried to address #47. While comparing my results to AbstractAlgebra I found some weird things though. I'm not sure if this is intended but it could to be related to the Expressions of AbstractAlgebra.

julia> 1//(i*j)
1//i*j

julia> 1//i*j
j//i
julia> e2p(1//q*i)//(3*q)
exp(2π𝑖(1//q*i))//3*q

julia> e2p(1//q*i)//3*q
1//3*q*exp(2π𝑖(1//q*i))

Maybe a simple * without spaces is supposed to represent implied multiplication.

@SoongNoonien
Copy link
Member Author

Ok, I forgot to adjust the doctests...

@SoongNoonien SoongNoonien marked this pull request as draft April 28, 2024 08:36
@SoongNoonien SoongNoonien marked this pull request as ready for review April 28, 2024 13:42
@fingolfin fingolfin merged commit 52d5122 into oscar-system:master Apr 29, 2024
4 of 5 checks passed
@SoongNoonien SoongNoonien deleted the cyclo_show branch August 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants