Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move info method to GenericCharacter.jl #199

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

SoongNoonien
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (acdda80) to head (bc2ef70).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #199       +/-   ##
===========================================
+ Coverage   61.15%   95.77%   +34.62%     
===========================================
  Files          12       13        +1     
  Lines         780      781        +1     
===========================================
+ Hits          477      748      +271     
+ Misses        303       33      -270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien
Copy link
Member Author

@fingolfin Do you have any idea why such a change could make the 1.11 test fail?

@SoongNoonien
Copy link
Member Author

Ok, apparently the test bots are broken. At least they refuse to test #200.

@SoongNoonien SoongNoonien merged commit 824af87 into oscar-system:master Sep 25, 2024
7 checks passed
@SoongNoonien SoongNoonien deleted the move_info branch October 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant