-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize manual #185
Reorganize manual #185
Conversation
Grouping things differently in a way that makes more sense to me personally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 13 13
Lines 837 837
=======================================
Hits 766 766
Misses 71 71 ☔ View full report in Codecov by Sentry. |
|
||
```@docs | ||
ortho2norm | ||
ortho2scalar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename those to norm resp scalar_product ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good idea. As we don't have the old index based methods for the characters anymore we should get any conflicts.
@SoongNoonien any objections or concerns? I mainly moved things around and added TODO comments (I'll resolve a few later but I wanted to get the basic structure right first) |
No, none. The structure of GenericCharacterTables has been deviating form the docs for quite some time now. |
Grouping things differently in a way that makes more sense to me personally.