Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize manual #185

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Reorganize manual #185

merged 1 commit into from
Sep 24, 2024

Conversation

fingolfin
Copy link
Member

Grouping things differently in a way that makes more sense to me personally.

Grouping things differently in a way that makes more sense to me personally.
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (0efc66a) to head (1ccc363).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          13       13           
  Lines         837      837           
=======================================
  Hits          766      766           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


```@docs
ortho2norm
ortho2scalar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename those to norm resp scalar_product ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea. As we don't have the old index based methods for the characters anymore we should get any conflicts.

@fingolfin
Copy link
Member Author

@SoongNoonien any objections or concerns? I mainly moved things around and added TODO comments (I'll resolve a few later but I wanted to get the basic structure right first)

@SoongNoonien
Copy link
Member

@SoongNoonien any objections or concerns?

No, none. The structure of GenericCharacterTables has been deviating form the docs for quite some time now.

@fingolfin fingolfin merged commit 7c5d868 into master Sep 24, 2024
7 checks passed
@fingolfin fingolfin deleted the mh/docs branch September 24, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants