Revert "try to work around some nightly issue" #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3b566a.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
=======================================
Coverage 75.78% 75.78%
=======================================
Files 51 51
Lines 4204 4204
=======================================
Hits 3186 3186
Misses 1018 1018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d3b566a.
Since JuliaLang/julia#54604 is merged, the workaround issue should no longer be present in julia nightly. Let's verify this with CI.
This PR should only get merged once JuliaLang/julia#54604 is backported to 1.11 and the next 1.11-nightly is released. Otherwise
run_with_overrideis broken on 1.11 prereleases (but not tested in CI).