feat(RHIF-255): Add Zero State to image builder #1231

adonispuente · 2023-07-11T20:07:42Z

This PR adds zero state to image builder.
To test use an account with zero systems, or change the logic for what the state is supposed to show and verify things look correct.

This zero state should pop up when there are 0 images on the account.

Fixes https://issues.redhat.com/browse/HMS-2184

codecov · 2023-07-11T20:14:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44e2a95) 73.30% compared to head (dbe9748) 73.59%.
Report is 193 commits behind head on main.

❗ Current head dbe9748 differs from pull request most recent head a7257eb. Consider uploading reports for the commit a7257eb to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
+ Coverage   73.30%   73.59%   +0.29%     
==========================================
  Files          70       69       -1     
  Lines        2000     1992       -8     
  Branches      529      527       -2     
==========================================
  Hits         1466     1466              
+ Misses        483      475       -8     
  Partials       51       51

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e2a95...a7257eb. Read the comment docs.

croissanne · 2023-07-13T10:14:28Z

Thank you! A few thoughts:

Now that edge is also integrating, I think we should figure out how those two are supposed to play together.
I wonder if we should show it when linking directly to the wizard
The beta prompt/popup is no longer visible if there's no images

@arburka @kelseamann would you mind taking a look as well?

arburka · 2023-07-18T16:42:00Z

Edge integration should not affect when this screen is shown. The zero state is shown when the "star" box in this flow happens (link)

If we link directly to the wizard, this should/could still show below it if the logic is sound. The button on the page evokes the wizard as well.

Yes, the beta prompt will not be visible. This is ok as we are close to removing them for these features and we would want to show that content in a similar way if we plan to highlight it here.

For example, we would want to add custom content to this page.

src/Router.js

lucasgarfield · 2023-08-16T16:12:02Z

Hi @adonispuente, would you mind squashing the second commit into the first one?

lavocatt · 2023-09-11T09:38:58Z

It would be nice to wait up until #1320 is merged so that we can use the new hook to know how many images are in the images table.

src/Router.js

src/Components/ShareImageModal/RegionsSelect.tsx

src/Components/ShareImageModal/ShareImageModal.tsx

src/Router.tsx

lavocatt · 2023-10-11T08:02:38Z

The unit tests are fixed @jrusz all good for you to test it.

jrusz · 2023-10-11T08:08:36Z

The unit tests are fixed @jrusz all good for you test it.

Thanks! I'll get on it.

jrusz · 2023-10-11T08:46:56Z

/retest

jrusz · 2023-10-11T09:30:21Z

/retest

jrusz · 2023-10-11T12:54:35Z

/retest

jrusz · 2023-10-11T13:58:23Z

Lol it actually passed 😄 ... Since I know already where to update the ouiaID I'm going to do that and then change it a little bit to make it more stable.

lavocatt

Quoting @croissanne:

Theoretically there are 3 "empty" states: an empty page state (returning user who's images expired), the zeroState, and the unentitled page.The unentitled page is of no concern to us because as soon as you have RHEL you're entitled. The empty page state will go away with blueprints (since those don't expire). Meaning after blueprints we can do the new zerostate.

There's no good ways to distinguish between the 3 states rn, so I'm blocking this work up until the blueprints wizard is there.

github-actions · 2023-11-13T04:04:27Z