Skip to content

Commit

Permalink
wizard: don't show the form as a modal
Browse files Browse the repository at this point in the history
When the user clicks on the "create an image" button, the image wizard
shows up replacing the landing page. This allows to keep the quickstart
guides to the right of the wizard while the user is interacting with it.
  • Loading branch information
lavocatt committed Oct 9, 2023
1 parent 382b019 commit 2b0276d
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/Components/CreateImageWizard/CreateImageWizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -641,15 +641,15 @@ const CreateImageWizard = () => {
name: 'image-builder-wizard',
className: 'imageBuilder',
isDynamic: true,
inModal: true,
inModal: false,
onKeyDown: (e) => {
handleKeyDown(e, handleClose);
},
buttonLabels: {
submit: 'Create image',
},
showTitles: true,
title: 'Create image',
title: 'Image Builder',
crossroads: [
'target-environment',
'release',
Expand Down
17 changes: 17 additions & 0 deletions src/Components/CreateImageWizard/CreateImageWizard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,20 @@ ul.pf-m-plain {
padding-left: 0;
margin-left: 0;
}

// [2023-09] Wizard height should not be limited see
// https://github.com/data-driven-forms/react-forms/issues/1402
// TODO remove me after DDF is not used anymore
.pf-c-wizard__main {
overflow-x: unset;
overflow-y: unset;
}
// TODO remove me after DDF is not used anymore
.pf-c-wizard__footer {
z-index: unset;
}
// [2023-10] Wizard closing cross shouldn't get displayed
// TODO remove me after DDF is not used anymore
.pf-c-wizard__header .pf-c-button.pf-m-plain {
display: none;
}
16 changes: 8 additions & 8 deletions src/Router.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ export const Router = () => {
</Suspense>
}
>
<Route
path="imagewizard/:composeId?"
element={
<Suspense>
<CreateImageWizard />
</Suspense>
}
/>
<Route path="share/:composeId" element={<ShareImageModal />} />
</Route>

<Route
path="imagewizard/:composeId?"
element={
<Suspense>
<CreateImageWizard />
</Suspense>
}
/>
{edgeParityFlag && (
<Route
path={`/${manageEdgeImagesUrlName}/:imageId`}
Expand Down

0 comments on commit 2b0276d

Please sign in to comment.