fix(agp): do not apply namespace if its not available

[osamaqarem]

Based on software-mansion/react-native-gesture-handler#2448

[KrzysztofMoch]

I think we should add back package="com.reactnativeimagecolors" in android manifest to support older versions

[KrzysztofMoch]

Also should we try implement this solution ? Example here

[osamaqarem]

yeah we should add it back, thanks for catching that. but i'm not sure about conditionally taking it out too via code - it might be ignored react-native-community/discussions-and-proposals#671 (comment) but I need to test it.

[atlj]

@osamaqarem Please see the following comment as well: react-native-community/discussions-and-proposals#671 (comment)

[KrzysztofMoch]

@osamaqarem can i complete this PR or you have already changes on local ?

[osamaqarem]

I'm thinking to close this PR as integration of expo-modules-core requires AGP 7 minimum, which means if you're on RN67 (AGP 4) you had to upgrade your AGP to 7 to use expo-modules-core in the first place.

In other words, if we were never compatible with AGP 4 (RN67 and below) then we never broke backward compatibility.

I couldn't find docs that say this, but there is this comment on a related issue
expo/expo#17862 (comment)

And then implicitly by expo-modules-core manual integration steps (setting AGP to 7.4):
https://docs.expo.dev/bare/installing-expo-modules/

Lastly, there is guide on from expo about changes needed for custom expo modules about those Gradle/AGP changes, and they don't address the concern of backward compatibility.
https://github.com/expo/fyi/blob/main/expo-modules-gradle8-migration.md

[KrzysztofMoch]

Okay, sounds reasonable

[osamaqarem]

I did some testing, and our v2.0.0 release only works with RN>0.70 which matches up to Expo SDK 47
https://docs.expo.dev/versions/latest/#support-for-android-and-ios-versions

This makes sense as per our README for Expo we specify SDK 47 as the minimum. I'll close this PR and update the README mentioning the missing requirement of > RN70 for bare apps, and i'll suggest v1 for older users.