-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added protoc 3.11.4 for osx-aarch_64. #94
base: master
Are you sure you want to change the base?
Conversation
Built with static linkage: ./configure --disable-shared Built from [email protected]:protocolbuffers/protobuf.git tag v3.11.4 Symbols stripped with "strip" % otool -L bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe: /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11) /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 904.4.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.60.1)
HI guys, do you have some idea when this PR will be merged and published? This will help a lot of M1 users. Thanks. |
Hi, we need this change too. Can we help some how? Thank you!! |
The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something.. |
Define "sponsorship"? As I need this I am also willing to help on it, but need it for private uses not for my current employer. |
Hi @os72 . Not sure if it's enough (probably not) but I just did a tiny buymeacoffee contribution for you. Just hoping that this PR is merged so that we can use this maven plugin out of the box for M1 macbooks instead of doing any complex workarounds. |
Hi @os72, |
hi @os72, |
Hi @os72, you are basically saying, you would rather let this project die if there is no sponsorship to give you the resources to work on this by yourself? Why don't you accept other contributors who actually have the time to work on this in their spare time? If you don't have the time, kindly let others do what they can. That's part of open source software, isn't it? |
Hi @os72! I confirmed that we (Spotify) were able to secure corporate sponsorship for protoc-jar. Can we unblock this PR? |
Also Google published, in latest version ready artefacts for this architecture - no longer need for custom builds |
There is one more option - fork. |
it's better - this repo can be archived! We have official artefacts from Google. @clairemcginty plese use something like bellow
|
@slachiewicz - you are confusing |
@daveish - not sure i understand this comment, this is open to anyone to modify (keyword fork).. |
hi @clairemcginty - this is awesome and very appreciated! kudos to spotify for showing some serious OSS leadership i'm not sure the process has completed, but yes this will help unfreeze the project. hopefully word can spread (beyond just spotify) and help establish a long-term sustainable maintenance level for the project |
When can we expect this to be merged |
Would be really great if you could merge this any time soon |
By when we expect this to close? |
One of workarounds for error wth protoc v3.11.4 and JDK 11.0.6 is maven goal parameter: mvn install -Dos.arch=x86_64 |
I tested this PR and it works perfectly. |
Please checkout the fork by BlackRock: https://github.com/blackrock/protoc-jar-maven-plugin This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64. |
Seems like the README should refer to protoc-maven-plugin? I can only find jars under https://repo1.maven.org/maven2/io/github/blackrock/protoc-maven-plugin/2.0.0/ and not under https://repo1.maven.org/maven2/io/github/blackrock/protoc-jar-maven-plugin/2.0.0/ |
@cmardini , you are correct. This is a missed on my part, thank you for pointing this out. I will get this updated. |
Built from
[email protected]:protocolbuffers/protobuf.git
tagv3.11.4
Symbols stripped with "strip"
Built with static linkage:
./configure --disable-shared
Note the license at: https://github.com/protocolbuffers/protobuf/blob/master/LICENSE