fix(cmdx): use better yaml library

ory · Mar 24, 2022 · 28892fd · 28892fd
1 parent 5be2287
commit 28892fd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmdx/printing.go b/cmdx/printing.go
@@ -153,7 +153,7 @@ func PrintJSONAble(cmd *cobra.Command, d interface{ String() string }) {
 		if i, ok := d.(interfacer); ok {
 			v = i
 		}
-		printJSON(cmd.OutOrStdout(), v, true)
+		printYAML(cmd.OutOrStdout(), v)
 	}
 }
 
@@ -202,7 +202,9 @@ func printJSON(w io.Writer, v interface{}, pretty bool) {
 }
 
 func printYAML(w io.Writer, v interface{}) {
-	e, err := yaml.Marshal(v)
+	j, err := json.Marshal(v)
+	Must(err, "Error encoding JSON: %s", err)
+	e, err := yaml.JSONToYAML(j)
 	Must(err, "Error encoding YAML: %s", err)
 	_, _ = w.Write(e)
 }

diff --git a/cmdx/printing_test.go b/cmdx/printing_test.go
@@ -263,7 +263,7 @@ func TestPrinting(t *testing.T) {
 				},
 				{
 					fArgs:    []string{"--" + FlagFormat, string(FormatYAML)},
-					expected: "[]",
+					expected: "null",
 				},
 			} {
 				t.Run(fmt.Sprintf("format=%v", tc.fArgs), func(t *testing.T) {