Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context param to policy #4315

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Feb 20, 2025

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested review from aeneasr and a team as code owners February 20, 2025 11:21
@hperl hperl requested a review from jonas-jonas February 20, 2025 11:21
@hperl hperl self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (687d578) to head (9a9beaf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/oidc/strategy.go 66.66% 1 Missing ⚠️
selfservice/strategy/oidc/strategy_login.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4315   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         381      381           
  Lines       27454    27454           
=======================================
  Hits        21569    21569           
  Misses       4252     4252           
  Partials     1633     1633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl merged commit 261596b into master Feb 20, 2025
30 of 31 checks passed
@hperl hperl deleted the hperl/ctx-aware-confict-identity-policy branch February 20, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants