Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept login challenge in session_issuer on SPA flows #4288

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas requested review from aeneasr and a team as code owners February 3, 2025 12:49
@jonas-jonas jonas-jonas self-assigned this Feb 3, 2025
@jonas-jonas jonas-jonas changed the title fix: accept login challenge in session_issue on SPA flows fix: accept login challenge in session_issuer on SPA flows Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (119841a) to head (392010b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/flow/continue_with.go 60.00% 4 Missing ⚠️
selfservice/hook/session_issuer.go 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4288   +/-   ##
=======================================
  Coverage   78.58%   78.59%           
=======================================
  Files         381      381           
  Lines       27370    27404   +34     
=======================================
+ Hits        21509    21537   +28     
- Misses       4238     4243    +5     
- Partials     1623     1624    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas enabled auto-merge (squash) February 3, 2025 14:39
@jonas-jonas jonas-jonas merged commit e13687a into master Feb 3, 2025
24 of 25 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/acceptLoginChallengeSPASession branch February 3, 2025 15:10
mpauly-exnaton pushed a commit to mpauly-exnaton/kratos that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants