Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: screen=previous two step registration #4209

Closed
wants to merge 1 commit into from
Closed

fix: screen=previous two step registration #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions selfservice/strategy/profile/two_step_registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@
return s.handleRegistrationError(r, regFlow, params, err)
}

if params.Method == "profile" || params.Screen == RegistrationScreenCredentialSelection {
return s.displayStepTwoNodes(ctx, w, r, regFlow, i, params)
} else if params.Method == "profile:back" {
if params.Method == "profile:back" {

Check warning on line 144 in selfservice/strategy/profile/two_step_registration.go

View check run for this annotation

Codecov / codecov/patch

selfservice/strategy/profile/two_step_registration.go#L144 

Added line #L144 was not covered by tests
// "profile:back" is kept for backwards compatibility.
span.AddEvent(semconv.NewDeprecatedFeatureUsedEvent(ctx, "profile:back"))
return s.displayStepOneNodes(ctx, w, r, regFlow, params)
} else if params.Screen == RegistrationScreenPrevious {
return s.displayStepOneNodes(ctx, w, r, regFlow, params)
} else if params.Method == "profile" || params.Screen == RegistrationScreenCredentialSelection {
return s.displayStepTwoNodes(ctx, w, r, regFlow, i, params)

Check warning on line 151 in selfservice/strategy/profile/two_step_registration.go

View check run for this annotation

Codecov / codecov/patch

selfservice/strategy/profile/two_step_registration.go#L150-L151 

Added lines #L150 - L151 were not covered by tests
}

// Default case
Expand Down
Loading