Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast add credential type lookups #4177

Merged
merged 2 commits into from
Oct 29, 2024
Merged

feat: fast add credential type lookups #4177

merged 2 commits into from
Oct 29, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 28, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr marked this pull request as ready for review October 28, 2024 13:50
@aeneasr aeneasr requested a review from alnr October 28, 2024 13:50
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (b4c453b) to head (ad4e21f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
persistence/sql/identity/persister_identity.go 84.21% 3 Missing and 3 partials ⚠️
x/sync_map.go 93.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
+ Coverage   78.57%   78.61%   +0.04%     
==========================================
  Files         379      380       +1     
  Lines       27042    27100      +58     
==========================================
+ Hits        21249    21306      +57     
+ Misses       4181     4180       -1     
- Partials     1612     1614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit eeb1355 into master Oct 29, 2024
29 checks passed
@aeneasr aeneasr deleted the types-looku branch October 29, 2024 10:24
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
mpauly-exnaton pushed a commit to mpauly-exnaton/kratos that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant