-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webhook config parse for settings flow #3305
fix: webhook config parse for settings flow #3305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3305 +/- ##
==========================================
- Coverage 78.09% 78.08% -0.02%
==========================================
Files 325 325
Lines 21092 21054 -38
==========================================
- Hits 16471 16439 -32
+ Misses 3391 3388 -3
+ Partials 1230 1227 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some tests to web_hook_integrations? Probably just a bit of copy & paste :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 🎉 Your contribution makes Ory better :)
Related issue(s)
#3252
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments