-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lark OIDC provider #2925
feat: lark OIDC provider #2925
Conversation
77d822e
to
233e784
Compare
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
- Coverage 78.04% 77.82% -0.23%
==========================================
Files 324 325 +1
Lines 21013 21074 +61
==========================================
Hits 16400 16400
- Misses 3384 3445 +61
Partials 1229 1229
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! :)
Could you please also add a bit of documentation for this feature? You can probably copy & paste content from: https://www.ory.sh/docs/kratos/social-signin/dingtalk
Sure, I submitted the document to this PR ory/docs#1145 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
200a6e5
to
009bf1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution :) I left 2 small comments and could provide a short video record of the full flow working? It will be easier also for us to see it live also
ab3b1d6
to
72b8e98
Compare
@piotrmsc here is a short screen record to show this flow works. t.mp4 |
and thank you for providing the recording :) |
@CNLHC any update here? could you resolve conflicts? :) |
a88ba2b
to
2483cbe
Compare
@piotrmsc I have rebased this PR to the master, resolved the conflict, and followed your suggestion. Now the special client is used to set the authorization header like this client = g.reg.HTTPClient(ctx,
httpx.ResilientClientDisallowInternalIPs(),
httpx.ResilientClientWithClient(o.Client(ctx, exchange))) |
Sorry for taking so long to merge this, thank you for keeping it up to date! |
Thank you for providing such an awesome project. I am glad to see this feature is finally merged. |
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
A Lark OIDC provider implementation, related to #2924