Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly redirect completed 2FA recovery flow to settings page with recovery message #2831

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmeller-wikia
Copy link
Contributor

@mmeller-wikia mmeller-wikia commented Oct 24, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@mmeller-wikia mmeller-wikia force-pushed the fix-recovery-flow-for-2fa-users branch from c8e3b48 to 5b66d72 Compare October 24, 2022 11:40
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Project coverage is 75.82%. Comparing base (4aab5e0) to head (5b66d72).
Report is 1103 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/link/strategy_recovery.go 43.75% 7 Missing and 2 partials ⚠️
identity/manager.go 42.85% 3 Missing and 5 partials ⚠️
session/manager_http.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   75.91%   75.82%   -0.09%     
==========================================
  Files         302      302              
  Lines       17898    17842      -56     
==========================================
- Hits        13587    13529      -58     
- Misses       3265     3271       +6     
+ Partials     1046     1042       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant