client: do not show/send secret when client is public #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a newly created public client had a secret send with the initial response and this secret was displayed in the CLI. Now it is clear that there is no secret needed for public clients. It is not displayed in the CLI anymore.
aeneasr
reviewed
Feb 6, 2018
client/sdk_test.go
Outdated
| @@ -71,7 +71,7 @@ func TestClientSDK(t *testing.T) { | |||
| c := hydra.NewOAuth2ApiWithBasePath(server.URL) | |||
| c.Configuration.Transport = httpClient.Transport | |||
|
|
|||
| t.Run("foo", func(t *testing.T) { | |||
| t.Run("client is created and updated", func(t *testing.T) { | |||
aeneasr
reviewed
Feb 6, 2018
client/sdk_test.go
Outdated
| @@ -106,4 +106,18 @@ func TestClientSDK(t *testing.T) { | |||
| require.NoError(t, err) | |||
| assert.Equal(t, http.StatusNotFound, response.StatusCode) | |||
| }) | |||
|
|
|||
| t.Run("public client is transmitted without secret", func(t *testing.T) { | |||
There was a problem hiding this comment.
Add case=public client is ... here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a newly created public client had a secret send with the initial response and this secret was displayed in the CLI.
Now it is clear that there is no secret needed for public clients. It is not displayed in the CLI anymore.
closes #737