Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faster GetPublicKeys #3787

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix: faster GetPublicKeys #3787

merged 3 commits into from
Jun 25, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 25, 2024

GetPublicKeys used to fetch all keys in a set, even if they were actually not being used. This patch fixes that.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

GetPublicKeys used to fetch all keys in a set, even if they were actually not being used. This patch fixes that.
@aeneasr aeneasr requested review from hperl and alnr as code owners June 25, 2024 13:55
@aeneasr aeneasr merged commit 04c34aa into master Jun 25, 2024
29 checks passed
@aeneasr aeneasr deleted the investigate-slow-keyset branch June 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants