Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix typo in host command help text #291

Merged
merged 8 commits into from
Oct 9, 2016
Merged

cmd: fix typo in host command help text #291

merged 8 commits into from
Oct 9, 2016

Conversation

mfzl
Copy link
Contributor

@mfzl mfzl commented Oct 9, 2016

^

@@ -45,8 +45,8 @@ CORE CONTROLS
- PORT: The port hydra should listen on.
Defaults to PORT=4444

- HOST: The port hydra should listen on.
Example: PORT=localhost
- HOST: The host interface hydra should listen on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to:

HOST: The host interface hydra should listen on. Leave empty to listen on all interfaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aeneasr
Copy link
Member

aeneasr commented Oct 9, 2016

Awesome, thanks! Will merge once tests are done

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@aeneasr aeneasr merged commit 6b9dd26 into ory:master Oct 9, 2016
emilva pushed a commit to emilva/hydra that referenced this pull request Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants