-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add front/backchannel logout params to client cli #2387
feat: add front/backchannel logout params to client cli #2387
Conversation
test failing on a |
If you merge master into this branch, the CI should work! |
Ah no sorry, I still have to fix something |
Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:
Thank you! |
Thanks! It seems like the Makefile is missing a
I ran the three commands in the
Seems CI is still not happy 😢 |
Try
For me it formats:
|
The Makefile is indeed missing a |
Looks like there's another makefile problem. Try:
|
88bd548
to
ab491fe
Compare
Thanks @aeneasr, that did the trick! |
Awesome, thank you! (: |
Related issue
#1487
Proposed changes
Adds client params related to OpenID Connect front/backchannel logout to the
hydra clients create
andhydra clients update
CLI commands.Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
make docs/cli
generated a lot of changes in the docs, perhaps it hadn't been run in awhile.