Consent: deduplicate user authenticated clients during logout. #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's strange of the message of the failure test is: |
|
The test failure is caused by a regression issue in the latest go releases. I fixed this in the upstream repo but have not had time yet to update the deps here. Will do so after the weekend, then this should pass!
… On 17. Aug 2019, at 19:38, Genchi ***@***.***> wrote:
Related issue
Proposed changes
I adjust ListUserAuthenticatedClientsWithFrontChannelLogout & ListUserAuthenticatedClientsWithBackChannelLogout, make it return unduplicated clients.
If one user login client A 100 times, and then logout after the latest login, it would send 100 requests to the front/backchannel of client A with the logout token with the same sid. It's a waste of performance to both Hydra and client A.
Checklist
I have read the contributing guidelines
I have read the security policy
I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
vulnerability, I confirm that I got green light (please contact ***@***.***) from the maintainers to push the changes.
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation within the code base (if appropriate)
I have documented my changes in the developer guide (if appropriate)
Further comments
You can view, comment on, or merge this pull request online at:
#1531
Commit Summary
Deduplicate user authenticated clients during logout.
File Changes
M consent/manager_memory.go (5)
M consent/manager_sql.go (2)
M consent/manager_test_helpers.go (66)
Patch Links:
https://github.com/ory/hydra/pull/1531.patch
https://github.com/ory/hydra/pull/1531.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This is now fixed on master - could you please rebase? |
|
Awesome - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Proposed changes
I adjust
ListUserAuthenticatedClientsWithFrontChannelLogout&ListUserAuthenticatedClientsWithBackChannelLogout, make it return unduplicated clients.If one user login client A 100 times, and then logout after the latest login, it would send 100 requests to the front/backchannel of client A with the logout token with the same sid. It's a waste of performance to both Hydra and client A.
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
Further comments