Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: Don't show registration_endpoint if config is undefined #1449

Merged
merged 2 commits into from
May 28, 2019

Conversation

sawadashota
Copy link
Contributor

Related issue

#1448

Proposed changes

Don't show registration_endpoint at /.well-known/openid-configuration if config is undefined.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

This update occurred when download dependencies

Signed-off-by: Shota Sawada <[email protected]>
@CLAassistant
Copy link

CLAassistant commented May 23, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented May 23, 2019

Thank you! That makes sense. By the way, I think omitempty works also with empty strings, no need for poimters afaik :)

@sawadashota
Copy link
Contributor Author

Thanks! Your are right!
https://play.golang.org/p/Typ4LJQ85Bl

@sawadashota sawadashota marked this pull request as ready for review May 23, 2019 09:17
@aeneasr aeneasr merged commit 6d46786 into ory:master May 28, 2019
@aeneasr
Copy link
Member

aeneasr commented May 28, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants