Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Improve configuration and service management #1314

Merged
merged 28 commits into from
Apr 2, 2019
Merged

config: Improve configuration and service management #1314

merged 28 commits into from
Apr 2, 2019

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 15, 2019

No description provided.

@aeneasr aeneasr added this to the v1.0.0 milestone Mar 15, 2019
Makefile Outdated
.PHONY: init
init:
go get -u \
GO111MODULE=off go get -u \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the tools.go solution (the "official" one for handling tool installs in module aware mode) so you only have to do go install here instead of GO111MODULE=off go get -u... (latest version of everything).

+Info: https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know that worked!

u
Signed-off-by: aeneasr <[email protected]>
aeneasr added 3 commits March 29, 2019 13:06
u
Signed-off-by: aeneasr <[email protected]>
# Conflicts:
#	client/sql_migration_files.go
#	cmd/root_test.go
#	cmd/server/handler_oauth2_factory.go
#	consent/handler.go
#	consent/sql_migration_files.go
#	go.mod
#	go.sum
#	jwk/sql_migration_files.go
#	oauth2/handler.go
#	oauth2/handler_struct.go
#	oauth2/sql_migration_files.go
aeneasr added 12 commits April 1, 2019 12:47
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
aeneasr added 4 commits April 2, 2019 11:16
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
u
Signed-off-by: aeneasr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants