Add check for empty subject in AcceptLoginRequest

[kminehart]

Signed-off-by: Kevin Minehart [email protected]

Related issue

#1254

Proposed changes

As per the discussion in the issue, subject should be required in the AcceptLoginRequest schema.

Checklist

• I have read the contributing guidelines
• I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
  vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
• I signed the Developer's Certificate of Origin
  by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
  amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
  force push.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation within the code base (if appropriate)
• I have documented my changes in the developer guide (if appropriate)

Further comments

Adding a validation check in the HTTP endpoint was the most straightforward way to prevent extra queries from happening if an empty subject was provided. That might not be the best place for checking for an empty subject.

I need to also make an accompanying a PR in ory/docs

ory/docs#111

[aeneasr]

LGTM - needs a test now :)

[aeneasr]

Almost done, just some cleaning up in the test!

[aeneasr]

Nice, good job :)